Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsdom connector tries to download data: uris #1240

Closed
molant opened this issue Aug 15, 2018 · 1 comment
Closed

jsdom connector tries to download data: uris #1240

molant opened this issue Aug 15, 2018 · 1 comment

Comments

@molant
Copy link
Member

molant commented Aug 15, 2018

Please tell us about your:

Environment

  • __hint version: 3.0.1
  • __Node.js version: 8.11.3
  • __npm version: 6.1.0

webhint configuration

`.hintrc`
{
  "extends": ["web-recommended"],
  "formatters": ["stylish"],
  "hints": {
    "axe": "off",
    "content-type": "off",
    "ssllabs": "off",
    "manifest-exists": "off",
    "x-content-type-options": "off",
    "http-cache": "warning",
    "http-compression": "warning"
  }
}

URL for which webhint failed

Output

webhint’s raw output
https://staging.smockle.com/ downloadedUnhandled Promise rejection: { error: Error: Invalid protocol: data:
    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\zone.js\dist\zone-node.js:811:33)
    at new AppInsightsAsyncCorrelatedErrorWrapper (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\applicationinsights\out\AutoCollection\CorrelationContextManager.js:193:18)
    at Request.init (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\request\request.js:458:31)
    at new Request (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\request\request.js:127:8)
    at request (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\request\index.js:53:10)
    at Requester._request (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\request\index.js:100:12)
    at Promise (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\@hint\utils-connector-tools\dist\src\requester.js:111:18)
    at new ZoneAwarePromise (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\zone.js\dist\zone-node.js:551:29)
    at Requester.get (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\@hint\utils-connector-tools\dist\src\requester.js:108:16)
    at JSDOMConnector._fetchUrl (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\@hint\connector-jsdom\dist\src\connector.js:35:34)
    at JSDOMConnector.fetchContent (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\@hint\connector-jsdom\dist\src\connector.js:223:21)
    at JSDOMConnector.fetchContent (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\@hint\connector-jsdom\dist\src\connector.js:221:25)
    at JSDOMConnector.resourceLoader (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\@hint\connector-jsdom\dist\src\connector.js:82:52)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7),
  uri: 'data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==' } ; Zone: <root> ; Task: Request.addListener:error ; Value: { error: Error: Invalid protocol: data:
    at AppInsightsAsyncCorrelatedErrorWrapper.ZoneAwareError (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\zone.js\dist\zone-node.js:811:33)
    at new AppInsightsAsyncCorrelatedErrorWrapper (C:\projects\sonarwhal-rename\www.smockle.com\node_modules\hint\node_modules\applicationinsights\out\AutoCollection\CorrelationContextManager.js:193:18)
@molant
Copy link
Member Author

molant commented Sep 5, 2018

I've seen something similar with msn, the chrome connector and blobs. Maybe something related with requester and the hints that use it to download again assets?

@sarvaje sarvaje self-assigned this Sep 5, 2018
sarvaje added a commit to sarvaje/hint that referenced this issue Sep 6, 2018
sarvaje added a commit to sarvaje/hint that referenced this issue Sep 6, 2018
sarvaje added a commit to sarvaje/hint that referenced this issue Sep 7, 2018
@molant molant closed this as completed in 09f4021 Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants