Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parser-css] Use postcss-safe-parser for fault tolerance [0.5] #1580

Closed
antross opened this issue Dec 13, 2018 · 0 comments · Fixed by #1757
Closed

[parser-css] Use postcss-safe-parser for fault tolerance [0.5] #1580

antross opened this issue Dec 13, 2018 · 0 comments · Fixed by #1757
Assignees
@antross @bruiztorres
Labels
area:parser difficulty:easy good first issue
Milestone
1901-2

Comments

@antross
Copy link
Member

antross commented Dec 13, 2018

Currently malformed CSS will cause the entire file to be ignored. By switching to use the fault-tolerant parser for PostCSS such files can still be analyzed, behaving more like a browser would.

https://github.com/postcss/postcss-safe-parser
@molant molant added this to the 1901-02 milestone Jan 14, 2019
@bruiztorres bruiztorres mentioned this issue Jan 17, 2019
Closed
4 tasks
@antross antross assigned bruiztorres and unassigned alrra Jan 18, 2019
antross added a commit to antross/hint that referenced this issue Jan 24, 2019
@antross
Fix: Gracefully handle malformed CSS
29760f1 
Fix webhintio#1580

Also update tests to run in parallel.
antross added a commit to antross/hint that referenced this issue Jan 24, 2019
@antross
Fix: Gracefully handle malformed CSS
10875f0 
Fix webhintio#1580

Also update tests to run in parallel.

Co-Authored-By: Borja Ruiz Torres <borgitas21@users.noreply.github.com>
@antross antross mentioned this issue Jan 24, 2019
Merged
3 tasks
@antross antross self-assigned this Jan 24, 2019
antross added a commit that referenced this issue Jan 25, 2019
@antross
Fix: Gracefully handle malformed CSS
ad9834c 
Fix #1580

Also update tests to run in parallel.

Co-Authored-By: Borja Ruiz Torres <borgitas21@users.noreply.github.com>
@antross antross changed the title [parser-css] Use postcss-safe-parser for fault tolerance [parser-css] Use postcss-safe-parser for fault tolerance [0.5] Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antross antross

@bruiztorres bruiztorres

Labels
area:parser difficulty:easy good first issue
Projects
None yet
Milestone
1901-2
Development

Successfully merging a pull request may close this issue.

Fix: Gracefully handle malformed CSS antross/hint
4 participants
@molant @antross @bruiztorres @alrra