Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New util to find chromium browser [1] #2260

Closed
molant opened this issue Apr 15, 2019 · 4 comments · Fixed by #2264
Closed

New util to find chromium browser [1] #2260

molant opened this issue Apr 15, 2019 · 4 comments · Fixed by #2264

Comments

@molant
Copy link
Member

molant commented Apr 15, 2019

This is a new util under packages/utils that allows to find the path of an installed chromium browser.
This will be based in chrome-finder from chrome-launcher.

List of browser to find (in Win, macOS, Linux, wsl?):

  • Chrome: Stable, Canary
  • Chromium
  • Edge: Dev, Canary
  • Opera: ?
  • Brave: ?
  • Others: ?

It will have a list of aliases (e.g.: edge-canary) that will automatically try to find the executable for that browser for the current platform.

It should also have a method to run the first one found. I think it should follow the same priority as chrome-launcher in case we end up contributing this upstream.

@molant
Copy link
Member Author

molant commented Apr 15, 2019

@paulirish let us know if this is something chrome-launcher might be interested and we can first test it here and contribute it later there!

@paulirish
Copy link

Yeah we'd be into this. sounds good.

molant added a commit to molant/hint that referenced this issue Apr 16, 2019
molant added a commit to molant/hint that referenced this issue Apr 16, 2019
@molant molant mentioned this issue Apr 16, 2019
4 tasks
molant added a commit to molant/hint that referenced this issue Apr 18, 2019
molant added a commit to molant/hint that referenced this issue Apr 18, 2019
antross pushed a commit that referenced this issue Apr 18, 2019
molant added a commit to molant/hint that referenced this issue Apr 18, 2019
@molant molant changed the title New util to find chromium browser New util to find chromium browser [1] Apr 18, 2019
molant added a commit to molant/hint that referenced this issue Apr 18, 2019
@paulirish
Copy link

@paulirish let us know if this is something chrome-launcher might be interested and we can first test it here and contribute it later there!

chrome-launcher is ready and waiting for it. ;)

@molant
Copy link
Member Author

molant commented Jul 23, 2019

Hi @paulirish 👋

I'm currently on parental leave so this will have to wait for a bit. I also ended up modifying more than I expected on that file so I'll have to revisit it 🤔
Another thing is that we want to support Firefox when their puppeteer support is out so probably this file will have to change again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants