New: Util chromium-finder
#2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've changed the implementation of |
sarvaje
suggested changes
Apr 16, 2019
molant
commented
Apr 17, 2019
molant
force-pushed
the
new/chromium-finder
branch
from
7178ca3
to
a48d59c
Compare
antross
approved these changes
Apr 17, 2019
sarvaje
reviewed
Apr 17, 2019
sarvaje
approved these changes
Apr 17, 2019
molant
force-pushed
the
new/chromium-finder
branch
2 times, most recently
from
a8d4c92
to
46b6482
Compare
molant
requested review from
antross and
sarvaje
and removed request for
antross
|
Changed applied. Ready for a last round. I'll start working on |
molant
force-pushed
the
new/chromium-finder
branch
from
46b6482
to
833d4e2
Compare
sarvaje
approved these changes
Apr 18, 2019
antross
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)
Fix #2260
I'll probably have to do more changes once I start working on #2139 and #2248 but this should be a good starting point.