Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate connector-chrome in favor of connector-puppeteer #2814

Closed
antross opened this issue Aug 13, 2019 · 0 comments · Fixed by #2972
Closed

Deprecate connector-chrome in favor of connector-puppeteer #2814

antross opened this issue Aug 13, 2019 · 0 comments · Fixed by #2972
Assignees
@molant
Milestone
1909-1

Comments

@antross
Copy link
Member

antross commented Aug 13, 2019

Yes, @hint/connector-puppeteer is intended to replace @hint/connector-chrome and nobody should write new code referencing the latter. Now that we've switched to @hint/connector-puppeteer as the default, we should be able to even mark the @hint/connector-chrome package as deprecated.

Originally posted by @antross in #2782 (comment)
molant added a commit to molant/hint that referenced this issue Sep 12, 2019
@molant
Fix: Deprecate connector-chrome
c9dce74 
Fix webhintio#2814
@molant molant mentioned this issue Sep 12, 2019
Merged
2 tasks
@molant molant self-assigned this Sep 12, 2019
@molant molant added this to the 1909-1 milestone Sep 12, 2019
molant added a commit to molant/hint that referenced this issue Sep 12, 2019
@molant
Fix: Deprecate connector-chrome
446323a 
Fix webhintio#2814
molant added a commit to molant/hint that referenced this issue Sep 12, 2019
@molant
Fix: Deprecate connector-chrome
9a2aba5 
Fix webhintio#2814
antross pushed a commit that referenced this issue Sep 14, 2019
@molant @antross
Fix: Deprecate connector-chrome
55c6118 
Fix #2814
Close #2972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@molant molant

Labels
None yet
Projects
None yet
Milestone
1909-1
Development

Successfully merging a pull request may close this issue.

Fix: Deprecate connector-chrome molant/hint
2 participants
@molant @antross