Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate size of VS Code extension bundle #2955

Closed
antross opened this issue Sep 9, 2019 · 0 comments · Fixed by #2983
Closed

Validate size of VS Code extension bundle #2955

antross opened this issue Sep 9, 2019 · 0 comments · Fixed by #2983
Assignees
@antross
Labels
area:vscode type:testing
Milestone
1909-2

Comments

@antross
Copy link
Member

antross commented Sep 9, 2019

Should we do something similar to the browser extension where we have a size budget?

Yes, I'll file an issue to track that.

Originally posted by @antross in #2954 (comment)

This will help us ensure we don't add large dependencies unintentionally.
@antross antross changed the title > Should we do something similar to the browser extension where we have a size budget? Validate size of VS Code extension bundle Sep 9, 2019
@antross antross added this to the 1909-2 milestone Sep 13, 2019
@antross antross self-assigned this Sep 13, 2019
antross added a commit to antross/hint that referenced this issue Sep 14, 2019
@antross
Chore: Validate size of VS Code extension bundle
7eeb1ee 
Fix webhintio#2955
@antross antross mentioned this issue Sep 14, 2019
Merged
4 tasks
antross added a commit to antross/hint that referenced this issue Sep 16, 2019
@antross
Chore: Validate size of VS Code extension bundle
838fa51 
Fix webhintio#2955
molant pushed a commit that referenced this issue Sep 17, 2019
@antross @molant
Chore: Validate size of VS Code extension bundle
488fa03 
Fix #2955
Close #2983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antross antross

Labels
area:vscode type:testing
Projects
None yet
Milestone
1909-2
Development

Successfully merging a pull request may close this issue.

Chore: Validate size of VS Code extension bundle antross/hint
1 participant
@antross