Chore: Bundle VS Code extension with webpack #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molant
approved these changes
Sep 9, 2019
| @@ -25,12 +28,13 @@ export const installPackages = async (packages: string[], options?: InstallOptio | |||
|
|
|||
| /** | |||
| * Load the provided packages from the specified location. | |||
| * Always performs a dynamic load, even if bundled with webpack. | |||
There was a problem hiding this comment.
I think you are missing the why here 🙂
There was a problem hiding this comment.
Indeed I am - good catch!
Yes, I'll file an issue to track that. |
Reduces extension size and unblocks sharing utilities with other parts of webhint. - - - - - - - - - - Fix webhintio#2803
The implementation is generated by VS Code itself at runtime.
antross
force-pushed
the
bundle-vscode
branch
from
1bf35c4
to
62d0274
Compare
utsavized
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces extension size and unblocks sharing utilities
with other parts of webhint.
Fix #2803
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)