Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove '.serial' from all tests #1768

Merged
merged 6 commits into from
Jan 30, 2019

Conversation

sarvaje
Copy link
Contributor

@sarvaje sarvaje commented Jan 25, 2019

Fix #1693

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

@sarvaje sarvaje force-pushed the remove-serial-tests branch 3 times, most recently from 6135678 to 041e600 Compare January 26, 2019 00:53
@antross antross added this to the 1902-1 milestone Jan 28, 2019
@sarvaje sarvaje force-pushed the remove-serial-tests branch 2 times, most recently from e662b0b to 2d49fd6 Compare January 29, 2019 18:05
@sarvaje
Copy link
Contributor Author

sarvaje commented Jan 29, 2019

@molant @antross this should be ready to review.

Copy link
Member

@molant molant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good!

packages/connector-local/src/connector.ts Outdated Show resolved Hide resolved
packages/create-parser/tests/new-parser.ts Outdated Show resolved Hide resolved
packages/hint-http-compression/package.json Show resolved Hide resolved

const test = anyTest as TestInterface<HTMLContext>;

// proxyquire('../src/formatter', { 'fs-extra': fsExtra });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed, no?

Suggested change
// proxyquire('../src/formatter', { 'fs-extra': fsExtra });


// proxyquire('../src/formatter', { 'fs-extra': fsExtra });

// import HTMLFormatter from '../src/formatter';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// import HTMLFormatter from '../src/formatter';

@molant molant merged commit 76cd403 into webhintio:master Jan 30, 2019
@sarvaje sarvaje deleted the remove-serial-tests branch May 30, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tests] Remove .serial from all tests [3.3]
3 participants