Fix: Using formatter-stylish in CI by default.

[sarvaje]

Fix #2892

Pull request checklist

Make sure you:

• Signed the Contributor License Agreement
• Followed the commit message guidelines

For non-trivial changes, please make sure you also:

• Added/Updated related documentation.
• Added/Updated related tests.

Short description of the change(s)

[antross]

@molant Want to take a look?

My only concern is more general than specific to this change so I won't block on it. As we keep adding more special-case handling to our default configuration I think we should start considering how we can do this in a way that's easier to extend.

Today once someone adds their own .hintrc file they lose the benefits of this conditional logic. E.g. if someone extends web-recommended then output in CI will look different than before and they won't be able to analyze file system paths. They can certainly replicate these behaviors by passing different config files to hint themselves depending on the context, but the sudden change in functionality may be surprising.

[molant]

@antross can you please open an issue to discuss that? Probably part of the next version discussion we should have.

[molant]

What do you think about checking that stylish is not used if not in CI in one of the existing tests?

[antross]

@sarvaje want to add the test case @molant suggested so we can unblock and merge this PR?

[sarvaje]

ok

[sarvaje]

I'm taking a look to the code and that test case is already there:
https://github.com/webhintio/hint/pull/2893/files#diff-41369f12d00e1d73e14241156907f6ffR207
https://github.com/webhintio/hint/pull/2893/files#diff-41369f12d00e1d73e14241156907f6ffR207

[antross]

@sarvaje maybe I'm missing something, but I don't see a test that validates it only uses html and summary when NOT in CI...

[sarvaje]

not literally, but we are checking that the configuration is { extends: ["web-recommended"]} and {extends: ["development"]}

[molant]

It's weird to me that we have a test to check the formatters in one environment and not another.

[sarvaje]

The test is there, if it is not CI, the configuration is { extends: ["web-recommended"]} if it is in CI, the configuration is {extends: ["web-recommended"], formatters: ["stylish", "html"]}

If we are not in CI, the property formatter is not initialized and we are using whatever comes from the extends.

[sarvaje]

I can't check the property formatter, because when I'm not in CI, I only use the extends. And I don't think we should test here what the extends has by default.

[molant]

OK, then 👍