New: Add endpoint/data contract to log telemetry to internal api #3830
Conversation
---------------------------------------- Fix #3829
There was a problem hiding this comment.
@utsavized does your other telemetry PR (webhintio/telemetry#190) need to be deployed first?
| time: string; | ||
| }; | ||
|
|
||
| const appInsightsEndpoint = 'https://dc.services.visualstudio.com/v2/track'; | ||
| const telemetryEndPoint = 'https://webhint-telemetry.azurewebsites.net/api/log'; |
There was a problem hiding this comment.
@hxlnt just want confirmation this is what we want: to use our Azure Function to report the telemetry to app insights so we can clean up any extra information that we do not want to store.
Is that correct?
There was a problem hiding this comment.
Yes. Also, we may eventually want to redirect a custom subdomain (like webhint.io/telemetry) to this endpoint to make it more official. I talked about that with Tony, but we decided that we can do that as part of another task.
Yes. Telemetry, then hint, then webhint.io (that PR is coming after these get deployed) :) |
|
@molant Is this good to go? |
| measurements: Measurements; | ||
| name: string; | ||
| properties: Properties; | ||
| ver?: number; |
There was a problem hiding this comment.
Is the version added automatically when sending the telemetry? I know we have a few metrics around this.
There was a problem hiding this comment.
Is this tracking webhint version? A bunch of other places (including webhint.io) had this hardcoded to 2, so I thought this was the v2 of the app insights REST API. If you look at Line 84 of this file (before change), you will see if set to 2.
There was a problem hiding this comment.
Sounds good ... looks like that one is merged now, is this one good to go then?
Closes #3829