Update telemetry endpoint to match data contract #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molant
reviewed
Jun 18, 2020
| @@ -6,7 +6,7 @@ | |||
| "type": "node", | |||
| "request": "attach", | |||
| "port": 9229, | |||
| "preLaunchTask": "func: host start" | |||
| "preLaunchTask": "func: host start --cors *" | |||
There was a problem hiding this comment.
Just is just a debugging task, I found that I was always adding this to debug, so added it here.
There was a problem hiding this comment.
So by default, it's set to block CORS calls, so if I am testing API locally from webhint.io (from a different localhost port), then the calls will get rejected. This will allow that so I can test locally or from webhint.io or postman
| @@ -69,10 +69,12 @@ export const trackEvent = async (name: string, properties: any) => { | |||
| * @param name - Event name. | |||
| * @param properties - Properties to track. | |||
| */ | |||
| export const addToAppInsights = (name: string, properties: any = {}) => { | |||
| export const addToAppInsights = (name: string, properties: any = {}, measurements: any = {}, time: Date) => { | |||
| appInsightsClient.trackEvent({ | |||
There was a problem hiding this comment.
In the app insights package. I don't see a bump in package.json in this PR so I wonder what/when that changed.
There was a problem hiding this comment.
That's the Azure AI package, and it already accepts a measurement param.
|
@molant Is this good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.