Chore: Move evaluate to child process
#494
Conversation
qzhou1607-zz
requested review from
alrra,
austinkelleher,
molant,
patrick-steele-idem and
sarvaje
as code owners
|
|
||
| try { | ||
| const script: vm.Script = new vm.Script(source); | ||
| const evaluteResult = await script.runInContext(jsdomutils.implForWrapper(window.document)._global); |
There was a problem hiding this comment.
After navigate you should wait for this._options.waitFor as it does in jsdom.ts. In that way, you will have a version of the site as much similar to the parent one as possible
src/lib/rules/axe/axe.ts
Outdated
| @@ -11,7 +11,7 @@ import { AxeResults, Result as AxeResult, NodeResult as AxeNodeResult } from 'ax | |||
|
|
|||
| import { readFileAsync } from '../../utils/misc'; | |||
| import { debug as d } from '../../utils/debug'; | |||
| import { IAsyncHTMLElement, ITraverseEnd, IRule, IRuleBuilder, Severity } from '../../types'; // eslint-disable-line no-unused-vars | |||
| import { IAsyncHTMLElement, IRule, IRuleBuilder, Severity, ITraverseStart } from '../../types'; // eslint-disable-line no-unused-vars | |||
There was a problem hiding this comment.
Now that I think about it, we have a problem switching to traverse::start with chrome.
We might want to create a custom event for evaluating scripts and each connector can fire it when it is more appropriate.
Maybe something like canevaluate?
@sonarwhal/contributors what do you think?
There was a problem hiding this comment.
@molant I haven't encounter any issue with axe using chrome so far. What's the issue with using traverse::start in chrome?
Now that I think about it, we have a problem switching to traverse::start with chrome.
That way maybe we can have a more clear message to show when evaluate is running, like Running scripts..., rather than hanging at Traversing the DOM when it's actually evaluating.
Maybe something like canevaluate?
There was a problem hiding this comment.
I haven't encounter any issue with axe using chrome so far.
The problem is that we will be telling people to evaluate scripts on traverse::start. Those scripts could modify the DOM and alter the results. That's why I'd rather do all of that at the end of the process for chrome. With jsdom we don't have that problem because it is a separate process.
There was a problem hiding this comment.
@molant I put it back as traverse::end for now before we decide whether or not we should have a custom event.
There was a problem hiding this comment.
For reference, the discussion about this is now in #497
qzhou1607-zz
force-pushed
the
fix_spinner
branch
from
536d72f
to
2f34e68
Compare
qzhou1607-zz
force-pushed
the
fix_spinner
branch
from
2f34e68
to
cbb55cb
Compare
|
@alrra what do you think about the tagging of this PR? Maybe use a |
It's a user facing thing ("This solves the stuck spinner issue") so yes, use |
I'll update the commit message when squashing. There is a huge queue on travis an don't want to wait even more to merge this. |
evaluateto its child processevaluateontraverse::startThis solves the stuck spinner issue.
Fix #485