Fix: Fix issue sending messages too big for Azure Service Bus #31
Conversation
|
@sarvaje Just to make sure: the job status is changed to |
|
@qzhou1607 I will take a look to sonarwhal.com later to take into account these changes. |
| elementLine: -1, | ||
| line: -1 | ||
| }, | ||
| message: 'Error in sonar analyzing this rule', |
There was a problem hiding this comment.
Maybe say the name of the rule in the message?
There was a problem hiding this comment.
This is the message we are going to see when we expand the rule, so I'm not sure if it is necessary to show the name or not.
I don't have a strong opinion on it, so I can change it if you want to :)
There was a problem hiding this comment.
OK, I thought it was for logging. OK as it is
| elementLine: -1, | ||
| line: -1 | ||
| }, | ||
| message: 'This rule has a lot errors, please use Sonar in your local machine for more errors details', |
There was a problem hiding this comment.
This rule has too many errors. Please use sonar locally for more details
|
|
||
| return; | ||
| } | ||
|
|
||
| if (job.status === JobStatus.started) { | ||
| // When the a job is splitted we receive more than one messges for the status `started` |
There was a problem hiding this comment.
When a job is split we receive more than one message for the status
started
sarvaje
force-pushed
the
split-messages
branch
from
f11d311
to
9e14196
Compare
If a message is too big, we change the messages in the rules with error to a generic one. Also, if a worker fail, we continue updating the other rules in other workers. Fix webhintio#29
sarvaje
force-pushed
the
split-messages
branch
from
9e14196
to
0fc3999
Compare
|
@molant you mean that I can merge the PR in sonarwhal.com, right? webhintio/webhintio.github.io#260 |
|
Yes |
|
Done! |
If a message is too big, we change the messages in the rules with error to a generic one.
Also, if a worker fail, we continue updating the other rules in other workers.
Fix #29