Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests into the Azure Pipeline #842

Closed
molant opened this issue Oct 4, 2019 · 18 comments · Fixed by #845
Closed

Add integration tests into the Azure Pipeline #842

molant opened this issue Oct 4, 2019 · 18 comments · Fixed by #845

Comments

@molant
Copy link
Member

molant commented Oct 4, 2019

#810 needs to be done first.

The work is modify this line to call also the new script.
Something like npm run test-staging && node helpers/integration-tests.js

@uchemukolo
Copy link
Contributor

I will like to work on this issue @molant

@molant
Copy link
Member Author

molant commented Oct 8, 2019

Sure!

There's a PR for #810 (#843) so once that one lands feel free to submit a PR for this. Or if you don't want to wait, you can look into cherry-picking the change in #843 and create a new commit for this issue on top of it to see that everything works end-to-end.
We might have to do some gymnastics to rebase the final code once #843 gets merged (we've requested a couple changes) but we can help you with that if needed or we can take care of them before merging.

Does that sound like a good plan to you?
If you have any questions please don't hesitate to reach out to us!

@uchemukolo
Copy link
Contributor

uchemukolo commented Oct 8, 2019

Sounds good!
I just cloned the repo and followed all the steps on the readme but when i run npm start i get the below attached error. Am i doing something wrong?
@molant
Screenshot 2019-10-08 at 10 31 37 PM

@molant
Copy link
Member Author

molant commented Oct 8, 2019

Nope, that's fine. We have to update the docs 😓
If you navigate to https://localhost:4000/server/ you should see something more colorful.

In any case, for this to work you actually don't need to build the website as you will be testing the staging environment (https://sonarwhal-staging.azurewebsites.net).

@molant
Copy link
Member Author

molant commented Oct 8, 2019

@uchemukolo I'm working on improving the docs rights now. Look for a PR soon!

@molant
Copy link
Member Author

molant commented Oct 8, 2019

Actually I just skipped the PR and push to master. If you get the latest version running npm start should work now as you expected. Also I've updated the README.md. There's still a bit more of work we want to do (see #360) but this should unblock most of the people running into the same issue as you.

@uchemukolo
Copy link
Contributor

@molant I see that PR for #810 (#843) has been merged. I tried to pull the the latest changes locally using git pull but nothing was downloaded

@molant
Copy link
Member Author

molant commented Oct 14, 2019

Are you working on a fork of this repo? In a different branch? There are a few reasons why this could happen.

Can you run git branch -vv and paste the output to have a bit more information?

Thanks!

@uchemukolo
Copy link
Contributor

Yes I am working a a fork of the repo. Can I work directly from the original repo? @molant

@antross
Copy link
Member

antross commented Oct 15, 2019

We typically recommend working on a fork, but it does change the git flow slightly. You'll need to fetch from upstream to get the latest commits then rebase them onto your fork's master branch.

git checkout master
git fetch upstream
git rebase upstream/master

@sarvaje
Copy link
Contributor

sarvaje commented Oct 15, 2019

@uchemukolo I think you need to configure the upstream remote repository.

git remote add upstream https://github.com/webhintio/webhint.io.git

@uchemukolo
Copy link
Contributor

@sarvaje script to run integration tests has been added, but how do i test to know its working as expected?

@sarvaje
Copy link
Contributor

sarvaje commented Oct 15, 2019

I think you need to create a PR to run Azure pipeline

@molant
Copy link
Member Author

molant commented Oct 15, 2019

Yes, please create a PR to this project so Azure can run it. We might need to tweak something on our side as the code will not be in the master branch but that's fine.

@uchemukolo
Copy link
Contributor

I am still having issues getting the latest updates on the forked branch
i ran git remote add upstream https://github.com/webhintio/webhint.io.git
git fetch upstream
still not able to get the latest updates from master.

when I cloned the repo directly i was getting 403 error when I tried to push
Screenshot 2019-10-15 at 9 49 53 PM
cc: @molant @sarvaje

@molant
Copy link
Member Author

molant commented Oct 15, 2019

Can you please run git branch -vv and paste the output?

@uchemukolo
Copy link
Contributor

git branch -vv
Screenshot 2019-10-15 at 10 23 56 PM

@molant
Copy link
Member Author

molant commented Oct 15, 2019

Not sure in what state you are because git branch -vv says you are in master of upstream but the previous one says you are in detached mode 🤔

If you are in the branch with the changes can you try doing git push -u origin? That should hopefully create a new branch in your fork and then you can do a PR from the github website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants