Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call integration test from azure pipeline #845

Merged

Conversation

uchemukolo
Copy link
Contributor

@uchemukolo uchemukolo commented Oct 16, 2019

Pull request checklist

Make sure you:

Short description of the change(s)

Fix #842

  • Calls the integrated tests from azure pipeline

@jsf-clabot
Copy link

jsf-clabot commented Oct 16, 2019

CLA assistant check
All committers have signed the CLA.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@uchemukolo uchemukolo force-pushed the call-integration-test-from-azure-pipeline branch from 9269503 to 00f997d Compare October 16, 2019 17:10
@molant
Copy link
Member

molant commented Oct 16, 2019

And this is the status of CI

image

Looks like everything is working as it should 🎉🎉🎉

Can you remove the part after npm test so we can merge it?

Thank you so much!

@uchemukolo uchemukolo force-pushed the call-integration-test-from-azure-pipeline branch from 00f997d to 913b601 Compare October 16, 2019 18:08
@uchemukolo
Copy link
Contributor Author

Done @molant

Copy link
Member

@molant molant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarvaje @antross can you take a look when you have the time?

@molant molant merged commit bd5f5af into webhintio:master Oct 17, 2019
@molant
Copy link
Member

molant commented Oct 17, 2019

Thanks a lot @uchemukolo and congratulations in your first contribution to the webhint project 🎉

@antross
Copy link
Member

antross commented Oct 17, 2019

Thanks @uchemukolo, this will be great to help us catch regressions in the site before going to production! We've been burned by this a few times in the past.

@uchemukolo
Copy link
Contributor Author

Glad I could help @molant @antross
This is my first contribution to open source

@molant
Copy link
Member

molant commented Oct 18, 2019

This is my first contribution to open source

Double congratulations then! Hope it is the first of many. Let us know if there's anything we can do to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests into the Azure Pipeline
4 participants