Fix invalid fixer behaviour (no namespace, imported class, fcqn) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of file without namespace, when we have imported class and also used the same class with fcqn in the file (without leading `\`) import was removed and fcqn was replaced with the imported name. It leads to invalid class name in the file. Only import should be removed.
michalbundyra
added a commit
that referenced
this pull request
Oct 6, 2019
Fix invalid fixer behaviour (no namespace, imported class, fcqn)
michalbundyra
added a commit
that referenced
this pull request
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of file without namespace, when we have imported class and also used the same class with fcqn in the file (without leading
\) import was removed and fcqn was replaced with the imported name. It leads to invalid class name in the file. Only import should be removed.