Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulumi CLI - Download Binaries Into Local .webiny Folder #1947

Merged
merged 3 commits into from
Oct 8, 2021

Conversation

adrians5j
Copy link
Member

Changes

This PR changes the folder into which the Pulumi CLI is downloaded. By default, it would be downloaded into {project-root}/node_modules/@webiny/pulumi-sdk/pulumi, but that can cause a couple of different issues:

  • re-installing dependencies can delete downloaded Pulumi binaries / plugins, forcing the user to re-download everything
  • Pulumi CLI can store credentials.json file here, which can definitely introduce security-related issues

How Has This Been Tested?

Manual testing.

Documentation

This change will be included in the release notes.

@adrians5j adrians5j added the bug label Oct 8, 2021
@adrians5j adrians5j added this to the 5.16.0 milestone Oct 8, 2021
@adrians5j adrians5j merged commit 79027c6 into next Oct 8, 2021
@adrians5j adrians5j deleted the pulumi-cli-download-path-fix branch October 8, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant