Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to react 18 - fix build #1 #3773

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat: upgrade to react 18 - fix build #1 #3773

merged 1 commit into from
Dec 14, 2023

Conversation

neatbyte-vnobis
Copy link
Collaborator

Changes

First batch of fixes for project build after updating to react 18.
https://www.notion.so/webiny/Upgrade-to-React-18-ceacd9bbfcf74b39a7ceb70943c3afa7

Packages: react-composition.

How Has This Been Tested?

Manually.

Documentation

None.

@neatbyte-ivelychko
Copy link

@brunozoric
Could you please verify that this is the way you want to follow for fixing build errors after upgrading to react 18.

@brunozoric
Copy link
Contributor

@neatbyte-vnobis
If the package builds, it is ok. Types also look ok to me.
Btw. out of which branch did you creat this one? There was 68 files changed until I rebased it against the target branch.

@brunozoric brunozoric merged commit f24a82a into bruno/feat/upgrade-to-react-18 Dec 14, 2023
11 of 13 checks passed
@neatbyte-ivelychko
Copy link

neatbyte-ivelychko commented Dec 14, 2023 •
edited
Loading

Btw. out of which branch did you creat this one? There was 68 files changed until I rebased it against the target branch.

I have created it against this bruno/feat/upgrade-to-react-18 branch

P.S. I have seen the problem, won't happen again

brunozoric pushed a commit that referenced this pull request Dec 14, 2023
@neatbyte-vnobis @brunozoric
feat: upgrade to react 18 - fix build #1 (#3773)
3cc8a45
brunozoric pushed a commit that referenced this pull request Jan 11, 2024
@neatbyte-vnobis @brunozoric
feat: upgrade to react 18 - fix build #1 (#3773)
d07d0e4
brunozoric pushed a commit that referenced this pull request Jan 12, 2024
@neatbyte-vnobis @brunozoric
feat: upgrade to react 18 - fix build #1 (#3773)
5a520fc
brunozoric pushed a commit that referenced this pull request Jan 17, 2024
@neatbyte-vnobis @brunozoric
feat: upgrade to react 18 - fix build #1 (#3773)
9d03146
brunozoric pushed a commit that referenced this pull request Feb 6, 2024
@neatbyte-vnobis @brunozoric
feat: upgrade to react 18 - fix build #1 (#3773)
ae71e52
brunozoric pushed a commit that referenced this pull request Feb 14, 2024
@neatbyte-vnobis @brunozoric
feat: upgrade to react 18 - fix build #1 (#3773)
0d4166b
brunozoric pushed a commit that referenced this pull request Mar 13, 2024
@neatbyte-vnobis @brunozoric
feat: upgrade to react 18 - fix build #1 (#3773)
1999ba4
brunozoric pushed a commit that referenced this pull request Mar 18, 2024
@neatbyte-vnobis @brunozoric
feat: upgrade to react 18 - fix build #1 (#3773)
9644c8a
brunozoric pushed a commit that referenced this pull request Mar 28, 2024
@neatbyte-vnobis @brunozoric
feat: upgrade to react 18 - fix build #1 (#3773)
ba937da
brunozoric pushed a commit that referenced this pull request May 2, 2024
@neatbyte-vnobis @brunozoric
feat: upgrade to react 18 - fix build #1 (#3773)
bce5857
@brunozoric brunozoric deleted the neatbyte/react-18-build-1 branch May 6, 2024 07:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunozoric brunozoric brunozoric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neatbyte-vnobis @neatbyte-ivelychko @brunozoric