Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm webjar contents is different from npm artifact when published via GitHub url #1676

Open
SomeoneToIgnore opened this issue Nov 10, 2017 · 1 comment

Comments

@SomeoneToIgnore
Copy link

Library: https://github.com/polymer/polymer-build

I wanted to publish a WebJar for the library, but polymer-build search gave nothing hence I used the GitHub link and picked version 2.1.1

It generated the output: https://dl.bintray.com/webjars/maven/org/webjars/npm/github-com-polymer-polymer-build/2.1.1/

Then I was able to publish artifact by its name, picked the same version, got
https://dl.bintray.com/webjars/maven/org/webjars/npm/polymer-build/2.1.1/

Expected: both directories have WebJars with same contents
Actual: polymer-build-2.1.1.jar contains same files like npm package,
github-com-polymer-polymer-build-2.1.1.jar contain less files, for instance, babel-helpers.min.js which is a part of the library.

Apparently, GitHub deployment packs GitHub sources in a WebJar which not the intended release contents.
By the way, would it make any sense to package *-sources.jar files with actual code from GitHub?
For now they are empty for both library versions.

@jamesward
Copy link
Member

This is actually due to one pulling the git repo and one pulling from the NPM repo. For #1670 / Bower we need to make sure we pull from just the git repo to avoid these issues. For NPM it is tricky because what goes into the NPM repo is different from what is in the git repo. And we can't always swap a git repo for an NPM artifact. So I think we'll have to do more research into what the NPM command does here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants