You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected: both directories have WebJars with same contents
Actual: polymer-build-2.1.1.jar contains same files like npm package, github-com-polymer-polymer-build-2.1.1.jar contain less files, for instance, babel-helpers.min.js which is a part of the library.
Apparently, GitHub deployment packs GitHub sources in a WebJar which not the intended release contents.
By the way, would it make any sense to package *-sources.jar files with actual code from GitHub?
For now they are empty for both library versions.
The text was updated successfully, but these errors were encountered:
This is actually due to one pulling the git repo and one pulling from the NPM repo. For #1670 / Bower we need to make sure we pull from just the git repo to avoid these issues. For NPM it is tricky because what goes into the NPM repo is different from what is in the git repo. And we can't always swap a git repo for an NPM artifact. So I think we'll have to do more research into what the NPM command does here.
Library: https://github.com/polymer/polymer-build
I wanted to publish a WebJar for the library, but
polymer-build
search gave nothing hence I used the GitHub link and picked version 2.1.1It generated the output: https://dl.bintray.com/webjars/maven/org/webjars/npm/github-com-polymer-polymer-build/2.1.1/
Then I was able to publish artifact by its name, picked the same version, got
https://dl.bintray.com/webjars/maven/org/webjars/npm/polymer-build/2.1.1/
Expected: both directories have WebJars with same contents
Actual:
polymer-build-2.1.1.jar
contains same files like npm package,github-com-polymer-polymer-build-2.1.1.jar
contain less files, for instance,babel-helpers.min.js
which is a part of the library.Apparently, GitHub deployment packs GitHub sources in a WebJar which not the intended release contents.
By the way, would it make any sense to package
*-sources.jar
files with actual code from GitHub?For now they are empty for both library versions.
The text was updated successfully, but these errors were encountered: