Add button to toggle theme in header #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudvigHz
added
enhancement
LudvigHz
requested review from
AdrianAndersen,
ivarnakken,
juniwbjerde and
norbye
ivarnakken
requested changes
Aug 23, 2022
app/components/Header/index.js
Outdated
Comment on lines
218
to
239
| <ToggleTheme | ||
| loggedIn={loggedIn} | ||
| updateUserTheme={this.props.updateUserTheme} | ||
| username={this.props.currentUser?.username} | ||
| /> |
There was a problem hiding this comment.
I agree, but I think it should be in the user drop-down or something on mobile, so it's not too hard to get to.
There was a problem hiding this comment.
I have added it to the dropdown now (when logged in)
LudvigHz
force-pushed
the
theme-switcher
branch
from
8e8469b
to
98031f5
Compare
Screencast.from.08-30-2022.11.25.57.PM.webm
|
LudvigHz
force-pushed
the
theme-switcher
branch
from
98031f5
to
3e36959
Compare
The button is an icon that switches based on the current theme. If the user is logged in, the theme will also be persisted to the backend.
LudvigHz
force-pushed
the
theme-switcher
branch
from
3e36959
to
06d4310
Compare
ivarnakken
added
approved
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The button is an icon that switches based on the current theme. If the
user is logged in, the theme will also be persisted to the
backend.