Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues regarding the theme toggle buttons in the header #2926

Open
4 of 7 tasks
ivarnakken opened this issue Sep 11, 2022 · 0 comments · Fixed by webkom/lego-webapp#3875
Open
4 of 7 tasks

Issues regarding the theme toggle buttons in the header #2926

ivarnakken opened this issue Sep 11, 2022 · 0 comments · Fixed by webkom/lego-webapp#3875
Labels
bug-fix Pull requests that fix a bug enhancement Pull requests that make or issues that suggest enhancements, instead of just purely new features frontend good-first-issue Issues that might be good for newcomers level:medium

Comments

@ivarnakken
Copy link
Member

ivarnakken commented Sep 11, 2022

webkom/lego-webapp#2980 introduced buttons to toggle the theme in the header. Here's a collection of issues I have found regarding the feature. Any contribution fixing any of the issues below is much appreciated (know that you don't have to fix everything with one single PR).

  • When changing the theme through the dropdown, the other icon in the header is not updated accordingly. See image below for illustration.

  • When spamming the button (especially the upper one), it'll create a queue of theme changes, which to the user seems like the page is glitching (because it'll toggle between the different states after stopping the spamming).

  • The icon in the dropdown should change color when hovering over the entire row, and not just icon itself.

  • On the upper icon, the space that is clickable and the space that triggers the color change, are not the same.

  • The default color of the upper icons do not match, which is more noticeable on dark theme. See image below for illustration.

  • The text in the dropdown, "Endre tema", has a slightly bolder styling, and should preferably match the other rows, despite having a different color. See image above for illustration.

  • When changing the theme, the fancy nodes in the background will update. I think it would be better if it didn't - less stuff happening.

@ivarnakken ivarnakken added frontend level:medium enhancement Pull requests that make or issues that suggest enhancements, instead of just purely new features bug-fix Pull requests that fix a bug good-first-issue Issues that might be good for newcomers labels Sep 11, 2022
@ivarnakken ivarnakken reopened this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Pull requests that fix a bug enhancement Pull requests that make or issues that suggest enhancements, instead of just purely new features frontend good-first-issue Issues that might be good for newcomers level:medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant