Allow multiple and other authors on articles #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasdeluna
force-pushed
the
articleauthornew
branch
from
e386a97
to
7eb5085
Compare
jonasdeluna
changed the title
jonasdeluna
force-pushed
the
articleauthornew
branch
from
7eb5085
to
b32b3c8
Compare
LudvigHz
requested changes
Feb 21, 2023
| </span> | ||
| </div> | ||
|
|
||
| { |
jonasdeluna
force-pushed
the
articleauthornew
branch
from
b32b3c8
to
b962f02
Compare
|
On default the author field will be the current user, and if the field is empty it will also be set to the current user upon validation as a security measure. |
LudvigHz
requested changes
Mar 4, 2023
There was a problem hiding this comment.
Sorry for suddenly finding more stuff here, I should have done a more thorough review the first time around 😞.
A couple things (as are mentioned in the comments):
- If authors is a required field in the backend, it should always be defined here, and both the types, and the usage of the
authorsfield should reflect that. So no null checks or anything here (array length checks are fine). Let the type system catch it. - Right now, the
authorsfield is set together with theObjectPermissions. This is not really related, and ObjectPermissions are generic fields that can be used on any field that use objectPermissions. I do like the idea of having default fields that can be reused super easy, but I doubt that we would have authors anywhere else than articles so with that in mind, both that it's not generic and that it does not have anything to do with ObjectPermissions, I think you should move it out and put the code for authors in the articleeditor directly.
| </span> | ||
| </div> | ||
|
|
||
| { |
jonasdeluna
force-pushed
the
articleauthornew
branch
from
b962f02
to
a74f318
Compare
jonasdeluna
force-pushed
the
articleauthornew
branch
3 times, most recently
from
8398ae0
to
50b66bb
Compare
LudvigHz
approved these changes
Mar 13, 2023
| component={SelectInput.AutocompleteField} | ||
| isMulti | ||
| filter={['users.user']} | ||
| id="article-title" |
Comment on lines
+229
to
+231
| type ValidationError<T> = Partial<{ | ||
| [key in keyof T]: string | Record<string, string>[]; | ||
| }>; |
Comment on lines
243
to
245
| if (!data.authors || data.authors.length === 0) { | ||
| errors.title = 'Forfatter er påkrevd'; | ||
| } |
There was a problem hiding this comment.
You should also be able to create a custom validation function for this and use createValidator like before
There was a problem hiding this comment.
This is entirely fine imo. though.
jonasdeluna
force-pushed
the
articleauthornew
branch
from
50b66bb
to
8cc4b97
Compare
|
Any reason to not merge this in now? @jonasdeluna You've done great work! |
ivarnakken
approved these changes
Mar 18, 2023
ivarnakken
added
approved
Thanks, not really unless the validator needs changing ill have a final look at the test today/in an hour |
jonasdeluna
force-pushed
the
articleauthornew
branch
from
d22eece
to
11da5b0
Compare
|
Everything should be good, but messed up the rebase :| also the backend tests are failing... |
jonasdeluna
force-pushed
the
articleauthornew
branch
from
11da5b0
to
0836303
Compare
jonasdeluna
force-pushed
the
articleauthornew
branch
3 times, most recently
from
9fa417d
to
5c959fa
Compare
…rs and refactor some code
jonasdeluna
force-pushed
the
articleauthornew
branch
from
66445b5
to
2ea8faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Option to add multiple/other users as author on articles.
Result
Before:
After:
Before:
After:
After:
Testing
Depends on: webkom/lego#3220
Resolves: webkom/lego#3195