Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change author on articles from one to many #3220

Merged
merged 1 commit into from Mar 20, 2023
Merged

Change author on articles from one to many #3220

merged 1 commit into from Mar 20, 2023

Conversation

jonasdeluna
Copy link
Member

image

@jonasdeluna jonasdeluna mentioned this pull request Feb 13, 2023
Merged
@jonasdeluna jonasdeluna requested a review from a team February 21, 2023 14:43
LudvigHz
LudvigHz requested changes Feb 21, 2023
View reviewed changes
lego/apps/articles/models.py Outdated Show resolved Hide resolved
lego/apps/articles/models.py Outdated Show resolved Hide resolved
lego/apps/articles/serializers.py Outdated Show resolved Hide resolved
lego/apps/articles/serializers.py Outdated Show resolved Hide resolved
@jonasdeluna jonasdeluna force-pushed the articleauthornew branch 2 times, most recently from 2cd36a8 to e3a2542 Compare February 28, 2023 18:44
@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (efff81b) 88.32% compared to head (8f4e873) 88.32%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3220   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files         659      660    +1     
  Lines       20845    20854    +9     
=======================================
+ Hits        18411    18420    +9     
  Misses       2434     2434
Impacted Files Coverage Δ
lego/apps/articles/tests/test_articles_api.py 100.00% <ø> (ø)
...o/apps/articles/migrations/0011_article_authors.py 100.00% <100.00%> (ø)
lego/apps/articles/models.py 100.00% <100.00%> (ø)
lego/apps/articles/serializers.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jonasdeluna jonasdeluna force-pushed the articleauthornew branch 3 times, most recently from 23a7973 to 4f396a9 Compare March 7, 2023 19:29
@ivarnakken ivarnakken added new-feature Pull requests that introduce or issues that suggest a new feature review-needed Pull requests that need review labels Mar 10, 2023
LudvigHz
LudvigHz requested changes Mar 13, 2023
View reviewed changes
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌. Just a few small things she this is good to go

lego/apps/articles/migrations/0012_rename_author_article_authors.py Outdated Show resolved Hide resolved
lego/apps/articles/serializers.py Outdated Show resolved Hide resolved
ivarnakken
ivarnakken approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I'm excited to get this in 🚀

Just fix up Ludvig's tiny comment and we're good!

@ivarnakken ivarnakken added approved Pull requests that have been approved changes-requested Pull requests with requested changes and removed review-needed Pull requests that need review labels Mar 14, 2023
@jonasdeluna jonasdeluna force-pushed the articleauthornew branch 2 times, most recently from e3b4c78 to 56d7da9 Compare March 16, 2023 09:31
@jonasdeluna jonasdeluna force-pushed the articleauthornew branch 2 times, most recently from 2edd8ab to 590858a Compare March 17, 2023 12:44
ivarnakken
ivarnakken reviewed Mar 18, 2023
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@jonasdeluna
Copy link
Member Author

Tests are failing is that supposed to happen

@PeterJFB
Copy link
Contributor

PeterJFB commented Mar 19, 2023 •
edited

Tests are failing is that supposed to happen

Yess
image

Failing likely since the tests now need to use the authors-field instead of author. The failing tests use get_data_with_author function in test_articles_api.py, changing it to an array should fix it :)

@jonasdeluna jonasdeluna merged commit ec70794 into master Mar 20, 2023
2 checks passed
@jonasdeluna jonasdeluna deleted the articleauthornew branch March 20, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudvigHz LudvigHz Awaiting requested review from LudvigHz

@ivarnakken ivarnakken Awaiting requested review from ivarnakken

Assignees
No one assigned
Labels
approved Pull requests that have been approved changes-requested Pull requests with requested changes new-feature Pull requests that introduce or issues that suggest a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonasdeluna @PeterJFB @LudvigHz @ivarnakken