New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information regarding rights as an eventmaker #3574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks solid! 💯 Thanks a lot!! 🤗
I've run this through our CI, and it's failing on linting. It seems like you might be running a different prettier
version than us? Simply run yarn prettier
and we should be all good! 😄
Also, you'll need to rebase this due to a tiny conflict.
EDIT: it looks like the conflict is due to the formatting, so you'll just need to format 😬
ec36228
to
5101cf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that there are still some problems with the cypress tests after running your changes through CI.
I've checked most of them, and it seems to all be related to the fact that you now have to check the box before you're allowed to create an event - and all the 8 tests that fail rely on being able to create an event.
If you click on the red cross on your last commit, and then click the "details" link for the cypress tests - you should have access to view the details about where each of the tests go wrong. (In short, you should make sure that the checkbox you added is always checked before the cy.contains('button', 'Opprett').should('not.be.disabled').click();
code is executed)
All the other tests seem to be good tho, so if you fix that it should be ready to merge 🤩
Description
A request from the big o Ledelsen that we include information about the rights you have (and don't have) when making an event.
Result
before
after
(after trying to submit an event without checking the box, and when hovering the text)