Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to arrangementskalender page from checkbox #3826

Merged
merged 1 commit into from Apr 23, 2023

Conversation

ingraso
Copy link
Member

@ingraso ingraso commented Apr 23, 2023

Description

Link to the arrangementskalender page from checkbox in EventEditor for easy access. Links are added both in the label and tooltip.

Result

Before
image

After
image

Before
image

After
image

Testing

  • I have thoroughly tested my changes.

Clicked the links and created an event just to be sure, even though the only changes are in the label and tooltip.


Resolves ABA-383

Both from label and tooltip, for easy access.
@ingraso ingraso added enhancement Pull requests that make enhancements, instead of just purely new features small-fix Pull requests that fix something small labels Apr 23, 2023
@ingraso ingraso self-assigned this Apr 23, 2023
@linear
Copy link

linear bot commented Apr 23, 2023

ABA-383 Event right checkbox should link to "arrangementskalender" page

Introduced here: #3574

It would be nice if it had a link to this page: https://abakus.no/pages/arrangementer/86-arrangementskalender for easy access.

@github-actions github-actions bot added the review-needed Pull requests that need review label Apr 23, 2023
@LudvigHz LudvigHz added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Apr 23, 2023
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes just what I imagined! Thanks🏅

arrangementskalenderen
</Link>{' '}
og Abakus sine blesteregler, og at jeg må ta kontakt med{' '}
<a href="mailto:hs@abakus.no">hs@abakus.no</a> dersom jeg er
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition💯

@ivarnakken ivarnakken added the ready-to-merge Pull requests that have been approved and are ready to be merged label Apr 23, 2023
@ivarnakken ivarnakken merged commit 85f9cd1 into master Apr 23, 2023
4 checks passed
@ivarnakken ivarnakken deleted the aba-383-link-to-arrangementskalender branch April 23, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features ready-to-merge Pull requests that have been approved and are ready to be merged small-fix Pull requests that fix something small
Projects
None yet
4 participants