Allow for admin registering multiple people at once #4220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace redux-form with react-final-form and clean up some of the routing and redux data fetching
eikhr
added
enhancement
eikhr
requested review from
danielyanghansen,
juniwbjerde,
ivarnakken,
Arashfa0301 and
jennymul
ABA-616 Allow admin påmelding of multiple students at the same time
Suggested by Birk in the email "Noen små innspill". It'd be nice to reply to him when the issue is fixed :) |
eikhr
force-pushed
the
multiple-admin-register
branch
from
1946e98
to
d620dc6
Compare
1 task
ivarnakken
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Thanks for getting rid of these at the same time 🙌🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced redux-form with react-final-form and cleaned up some of the routing and redux data fetching in eeae32c, then implemented the multi-select thing in 1946e98
Result
I changed the order of the form and added some required-marks as well:
Testing
I have tested admin-registering single people and multiple people. Have also tested that error messages show up as intended, both from local validation and server-errors.
Resolves ABA-616