Improve final-form submit-button and submission-error consistency #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikhr
added
enhancement
eikhr
requested review from
norbye,
danielyanghansen,
juniwbjerde and
ivarnakken
eikhr
force-pushed
the
use-submit-button-in-forms
branch
from
4cecd84
to
fd39362
Compare
eikhr
force-pushed
the
use-submit-button-in-forms
branch
from
fd39362
to
9df8353
Compare
eikhr
force-pushed
the
use-submit-button-in-forms
branch
from
9df8353
to
26047cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR builds on #4220 because I created the
<SubmitButton>-component there, only 59a86e1 is relevant.The
<SubmitButton>-component just reduces some boilerplate, with the bonus that it enforces consistency in submit-buttons.<SubmissionError>shows any errors that arise when submitting the form, meaning that the forms that were missing this would simply not show the error message.I also did a bit of refactoring in
CompanySemesterGUIbecause the previous structure made no sense.Result
Some forms had green or grey submit-buttons, now they are all black.
The login-form had a custom error-component which was simply red text, it now uses
<SubmissionError>:Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ... (either GitHub issue or Linear task)