Properly reject promises on server

app/routes/admin/email/components/EmailUsers.tsx

@@ -50,12 +50,12 @@ const EmailUsers = () => {
   usePreparedEffect(
     'fetchEmailUsers',
     () =>
-      Promise.resolve([
+      Promise.all([
         dispatch(fetchAllWithType(GroupType.Committee)),
         dispatch(fetchAllWithType(GroupType.Grade)),
         dispatch(fetch({ query })),
       ]),
-    []
+    [query]
   );
 
   const columns = [

app/routes/articles/components/Overview.tsx

@@ -92,11 +92,11 @@ const Overview = () => {
   usePreparedEffect(
     'fetchArticlesOverview',
     () =>
-      Promise.resolve([
+      Promise.all([
         dispatch(fetchPopular()),
         dispatch(fetchAll({ next: false, query })),
       ]),
-    []
+    [query]
   );
 
   const headlineEvents = articles.slice(0, HEADLINE_EVENTS);

app/routes/bdb/components/BdbDetail.tsx

@@ -78,15 +78,15 @@ const BdbDetail = () => {
   usePreparedEffect(
     'fetchBdbDetail',
     () =>
+      companyId &&
       Promise.all([
         dispatch(fetchSemesters()).then(() => dispatch(fetchAdmin(companyId))),
-        companyId &&
-          dispatch(
-            fetchEventsForCompany({
-              endpoint: `/events/${queryString(companyId)}`,
-              queryString: queryString(companyId),
-            })
-          ),
+        dispatch(
+          fetchEventsForCompany({
+            endpoint: `/events/${queryString(companyId)}`,
+            queryString: queryString(companyId),
+          })
+        ),
       ]),
     [companyId]
   );

app/routes/interestgroups/components/InterestGroupDetail.tsx

@@ -134,11 +134,11 @@ const InterestGroupDetail = () => {
     'fetchInterestGroupDetail',
     () =>
       groupId &&
-      Promise.resolve([
+      Promise.all([
         dispatch(fetchGroup(groupId)),
         loggedIn && dispatch(fetchAllMemberships(groupId)),
       ]),
-    [loggedIn]
+    [groupId, loggedIn]
   );
 
   return (

app/routes/meetings/MeetingDetailWrapper.tsx

@@ -38,7 +38,9 @@ const MeetingDetailWrapper = () => {
         dispatch(answerMeetingInvitation(action, token));
       }
 
-      return loggedIn ? dispatch(fetchMeeting(meetingId)) : Promise.resolve();
+      return loggedIn && meetingId
+        ? dispatch(fetchMeeting(meetingId))
+        : Promise.resolve();
     },
     [meetingId, loggedIn, token, action]
   );

app/routes/overview/components/PublicFrontpage.tsx

@@ -35,11 +35,7 @@ const PublicFrontpage = () => {
 
   const dispatch = useAppDispatch();
 
-  usePreparedEffect(
-    'fetchIndex',
-    () => Promise.all([dispatch(fetchData())]),
-    []
-  );
+  usePreparedEffect('fetchIndex', () => dispatch(fetchData()), []);
 
   const pinned = frontpage[0];
 

app/routes/pages/components/PageEditor.tsx

@@ -78,7 +78,7 @@ const PageEditor = () => {
 
   usePreparedEffect(
     'fetchPageEdit',
-    () => !isNew && dispatch(fetchPage(pageSlug)),
+    () => !isNew && pageSlug && dispatch(fetchPage(pageSlug)),
     [isNew, pageSlug]
   );
 

app/routes/photos/components/GalleryDetail.tsx

@@ -75,6 +75,7 @@ const GalleryDetail = () => {
   usePreparedEffect(
     'fetchGalleryDetail',
     () =>
+      galleryId &&
       Promise.all([
         dispatch(fetch(galleryId)).catch(),
         dispatch(fetchGallery(galleryId)).catch(() =>

app/routes/photos/components/GalleryPictureEditModal.tsx

@@ -55,9 +55,10 @@ const GalleryPictureEditModal = () => {
   usePreparedEffect(
     'fetchGalleryAndGalleryPicture',
     () =>
+      galleryId &&
       Promise.all([
         dispatch(fetchGallery(galleryId)),
-        dispatch(fetchGalleryPicture(galleryId, pictureId)),
+        pictureId && dispatch(fetchGalleryPicture(galleryId, pictureId)),
       ]),
     [galleryId, pictureId]
   );

app/routes/photos/components/GalleryPictureModal.tsx

@@ -187,9 +187,10 @@ const GalleryPictureModal = () => {
   usePreparedEffect(
     'fetchGalleryPicture',
     () =>
+      galleryId &&
       Promise.all([
-        dispatch(fetchGalleryPicture(galleryId, pictureId)),
         dispatch(fetchGallery(galleryId)),
+        pictureId && dispatch(fetchGalleryPicture(galleryId, pictureId)),
       ]),
     []
   );

app/routes/polls/components/PollDetail.tsx

@@ -23,7 +23,11 @@ const PollDetail = () => {
 
   const dispatch = useAppDispatch();
 
-  usePreparedEffect('fetchPoll', () => dispatch(fetchPoll(pollsId)), []);
+  usePreparedEffect(
+    'fetchPoll',
+    () => pollsId && dispatch(fetchPoll(pollsId)),
+    []
+  );
 
   const poll = useAppSelector((state) => selectPollById(state, pollsId));
   const fetching = useAppSelector((state) => state.polls.fetching);

app/routes/quotes/components/QuotePage.tsx

@@ -76,11 +76,11 @@ const QuotePage = () => {
   usePreparedEffect(
     'fetchQuotePage',
     () =>
-      Promise.resolve([
+      Promise.all([
         quoteId ? dispatch(fetchQuote(quoteId)) : dispatch(fetchAll({ query })),
         dispatch(fetchEmojis()),
       ]),
-    [query]
+    [quoteId, query]
   );
 
   return (