Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve weekly mail #3200

Merged
merged 1 commit into from Feb 7, 2023
Merged

Improve weekly mail #3200

merged 1 commit into from Feb 7, 2023

Conversation

erlingfn
Copy link
Contributor

@erlingfn erlingfn commented Feb 2, 2023

Improve the css of the joblistings table. Hard code date and times being displayed in Norwegian time.

@codecov
Copy link

codecov bot commented Feb 2, 2023 •
edited

Codecov Report

Base: 88.28% // Head: 88.28% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (9833410) compared to base (2ba138a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3200   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files         658      658           
  Lines       20712    20713    +1     
=======================================
+ Hits        18286    18287    +1     
  Misses       2426     2426
Impacted Files Coverage Δ
lego/apps/email/tasks.py 98.36% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ivarnakken ivarnakken added enhancement Pull requests that make or issues that suggest enhancements, instead of just purely new features review-needed Pull requests that need review labels Feb 2, 2023
@erlingfn erlingfn requested a review from norbye February 2, 2023 14:11
ivarnakken
ivarnakken requested changes Feb 2, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Word break was much needed

lego/apps/email/tasks.py Outdated Show resolved Hide resolved
@ivarnakken ivarnakken added the changes-requested Pull requests with requested changes label Feb 2, 2023
LudvigHz
LudvigHz approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@LudvigHz LudvigHz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (except for the pytz ofc)

@erlingfn
Improve weekly mail
9833410 
Improve the css of the joblistings table. Hard code date and times being
displayed in Norwegian time.
@ivarnakken ivarnakken added approved Pull requests that have been approved ready-to-merge Pull requests that have been approved and are ready to be merged and removed changes-requested Pull requests with requested changes review-needed Pull requests that need review labels Feb 7, 2023
@ivarnakken ivarnakken merged commit 7e08ba1 into master Feb 7, 2023
@ivarnakken ivarnakken deleted the improve-weekly-mail branch February 7, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norbye norbye norbye approved these changes

@LudvigHz LudvigHz LudvigHz approved these changes

@ivarnakken ivarnakken ivarnakken approved these changes

Assignees
No one assigned
Labels
approved Pull requests that have been approved enhancement Pull requests that make or issues that suggest enhancements, instead of just purely new features ready-to-merge Pull requests that have been approved and are ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erlingfn @norbye @LudvigHz @ivarnakken