Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reactions to meetings #3215

Merged
merged 1 commit into from Feb 28, 2023
Merged

Add reactions to meetings #3215

merged 1 commit into from Feb 28, 2023

Conversation

jonasdeluna
Copy link
Member

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 88.28% // Head: 88.26% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2955559) compared to base (5ed8b62).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3215      +/-   ##
==========================================
- Coverage   88.28%   88.26%   -0.02%     
==========================================
  Files         658      658              
  Lines       20714    20730      +16     
==========================================
+ Hits        18288    18298      +10     
- Misses       2426     2432       +6     
Impacted Files Coverage Δ
lego/apps/meetings/models.py 83.33% <50.00%> (-5.13%) ⬇️
lego/apps/meetings/serializers.py 95.31% <100.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jonasdeluna jonasdeluna requested a review from a team February 21, 2023 14:35
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I see now that the get_reactions_grouped ideally should be done in a query/SQL and not like this in python. Would speed things up a lot :)

@jonasdeluna jonasdeluna merged commit ba4fd6d into master Feb 28, 2023
@jonasdeluna jonasdeluna deleted the pizzareaction branch February 28, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants