Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll out weekly mail #3222

Merged
merged 2 commits into from Feb 21, 2023
Merged

Roll out weekly mail #3222

merged 2 commits into from Feb 21, 2023

Conversation

erlingfn
Copy link
Contributor

This PR does two things:

  • Send weekly mail to all users in organisation(ie. those in the Abakus group). Not just PR and Webkom
  • Make some minor improvements:
    • Add header with week number
    • Additional padding for joblistings
    • Make company name column wider

Screenshot:
image

Send weekly mail to all users part of the "Abakus" group, not just the
ones in PR or Webkom.
Add some minor improvements to weekly mail:
 - Additional spacing for joblistings
 - Header with week number
 - Expand width of company name column
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 88.29% // Head: 88.29% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (29f4605) compared to base (a69de21).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3222   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files         658      658           
  Lines       20728    20729    +1     
=======================================
+ Hits        18302    18303    +1     
  Misses       2426     2426           
Impacted Files Coverage Δ
lego/apps/email/tasks.py 98.38% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LudvigHz LudvigHz merged commit 3f4dd1b into master Feb 21, 2023
@LudvigHz LudvigHz deleted the roll-out-weekly-mail branch February 21, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants