Edit company interest model to include more fields #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arashfa0301
requested review from
eikhr,
LudvigHz,
juniwbjerde and
ivarnakken
Arashfa0301
added
priority:high
Arashfa0301
force-pushed
the
edit-company-interest
branch
3 times, most recently
from
5cc5c11
to
1a10c79
Compare
Codecov ReportBase: 88.29% // Head: 88.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3226 +/- ##
==========================================
+ Coverage 88.29% 88.31% +0.01%
==========================================
Files 658 659 +1
Lines 20728 20762 +34
==========================================
+ Hits 18302 18336 +34
Misses 2426 2426
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Arashfa0301
force-pushed
the
edit-company-interest
branch
from
1a10c79
to
852f57c
Compare
ivarnakken
reviewed
Feb 21, 2023
| @@ -53,7 +53,8 @@ def handle_create(self, instance, **kwargs): | |||
| # reply is sent to them (and bedkom) | |||
| recipients.append(mail_context["mail"]) | |||
| if mail_context["readme"]: | |||
| recipients.append(f"lederreadme@{settings.GSUITE_DOMAIN}") | |||
| # recipients.append(f"lederreadme@{settings.GSUITE_DOMAIN}") | |||
eikhr
reviewed
Feb 21, 2023
| @@ -53,7 +53,8 @@ def handle_create(self, instance, **kwargs): | |||
| # reply is sent to them (and bedkom) | |||
| recipients.append(mail_context["mail"]) | |||
| if mail_context["readme"]: | |||
| recipients.append(f"lederreadme@{settings.GSUITE_DOMAIN}") | |||
| # recipients.append(f"lederreadme@{settings.GSUITE_DOMAIN}") | |||
| recipients.append("redaktor@abakus.no") | |||
There was a problem hiding this comment.
Suggested change
| recipients.append("redaktor@abakus.no") | |
| recipients.append("redaktor@{settings.GSUITE_DOMAIN}") |
not that it matters much
danielyanghansen
approved these changes
Feb 21, 2023
Co-authored-by: Jonas de Luna Skulberg <jonasdls@gmail.com>
Arashfa0301
force-pushed
the
edit-company-interest
branch
from
852f57c
to
b196ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited the Company Interest in according to the requested changes by "Interkom"
All the above changes are thoroughly tested though the front end and the ensomnia app