Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect waiting list sorting #3227

Merged
merged 1 commit into from Feb 21, 2023
Merged

Fix incorrect waiting list sorting #3227

merged 1 commit into from Feb 21, 2023

Conversation

LudvigHz
Copy link
Member

@LudvigHz LudvigHz commented Feb 21, 2023 •
edited

On some events, usually with many users in the waiting list, the waiting
list is consistently wrong for all users (i.e. the sorting is the same,
incorrect for all users) when admitted to the event.

I'm not 100% sure why this works, but changing the query for the
prefetching on the event retrieve endpoint consistently gives the
correct sorting.

Fixes ABA-289

@LudvigHz
Fix incorrect waiting list sorting
86cdab6 
On some events, usually with many users in the waiting list, the waiting
list is consistently wrong for all users (i.e. the sorting is the same,
incorrect for all users) when admitted to the event.

I'm not 100% sure why this works, but changing the query for the
prefetching on the event retrieve endpoint consistently gives the
correct sorting.
@LudvigHz LudvigHz added priority:high Pull requests that have high priority, and should therefore be prioritized bug-fix Pull requests that fix a bug labels Feb 21, 2023
@LudvigHz LudvigHz requested a review from a team February 21, 2023 21:33
norbye
norbye approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to give a good review as I don't really understand this either, but I'm all for deploying it and checking how it works in prod 🚀

@LudvigHz LudvigHz merged commit c46dade into master Feb 21, 2023
@LudvigHz LudvigHz deleted the event-watinglist branch February 21, 2023 22:04
@linear
Copy link

linear bot commented Feb 21, 2023

ABA-289 Fix incorrect and unstable waiting list place

#3211 (comment)

@ivarnakken ivarnakken mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norbye norbye norbye approved these changes

Assignees
No one assigned
Labels
bug-fix Pull requests that fix a bug priority:high Pull requests that have high priority, and should therefore be prioritized
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LudvigHz @norbye