Fix bug sending 10+ mails to all users #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlingfn
requested review from
LudvigHz,
ivarnakken and
eikhr
and removed request for
LudvigHz
lgtm
LudvigHz
approved these changes
Feb 26, 2023
erlingfn
force-pushed
the
fix-big-problem-weekly-mail
branch
from
9af88e6
to
745d527
Compare
eikhr
approved these changes
Feb 26, 2023
The restricted lookup returns a list containing each user multiple times. This results in each user receiving multiple copies of each weekly mail(I think). This sends out the weekly mail to each user just once, and also just does it for students.
erlingfn
force-pushed
the
fix-big-problem-weekly-mail
branch
from
745d527
to
6038f82
Compare
ivarnakken
added
approved
Codecov ReportBase: 88.31% // Head: 88.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3229 +/- ##
=======================================
Coverage 88.31% 88.31%
=======================================
Files 659 659
Lines 20760 20770 +10
=======================================
+ Hits 18334 18344 +10
Misses 2426 2426
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restricted lookup returns a list containing each user multiple times. This results in each user receiving multiple copies of each weekly mail(I think). This sends out the weekly mail to each user just once, and also just does it for students.