Merge data from "created_by" to "authors" field #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasdeluna
added
the
do-not-merge/WIP
jonasdeluna
commented
Mar 23, 2023
jonasdeluna
force-pushed
the
migrate_authors
branch
2 times, most recently
from
684fe19
to
1dbe286
Compare
jonasdeluna
added
bug-fix
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3259 +/- ##
==========================================
- Coverage 88.33% 88.32% -0.01%
==========================================
Files 660 661 +1
Lines 20857 20868 +11
==========================================
+ Hits 18423 18431 +8
- Misses 2434 2437 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
LudvigHz
reviewed
Mar 24, 2023
jonasdeluna
force-pushed
the
migrate_authors
branch
from
1dbe286
to
67aa136
Compare
eikhr
reviewed
Mar 26, 2023
| def merge_authors(apps, schema_editor): | ||
| Article = apps.get_model("articles", "Article") | ||
| for e in Article.objects.all(): | ||
| if e.created_by != None and e.authors == None: |
There was a problem hiding this comment.
Should't this be e.authors != None, or can you do .add() anyways?
There was a problem hiding this comment.
It seemed to run fine for me. From testing in shell, the field is None if there's no entries and adding still works.
LudvigHz
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate data from the old created_by field to the new authors field holding multiple authors instead of one.