Replace urlparse() with the faster urlsplit() alternative
#3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarnakken
added
enhancement
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3286 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 661 661
Lines 20882 20882
=======================================
Hits 18444 18444
Misses 2438 2438
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urlparse() allows for “parameters” before the ? in the URL, which we do not use here.
urlsplit() supports a later (1998) RFC and does not parse such parameters. It's thus a bit faster.
Anthony Sottile did a video on the subject, which taught me about this difference.
This change makes a very little difference for us, but I just wanted to try it out for fun.