Implement Image Gallery Functionality & Endpoints #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jonasdeluna
force-pushed
the
imagegallery-newer
branch
from
330227e
to
9625172
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3312 +/- ##
==========================================
+ Coverage 88.16% 88.19% +0.02%
==========================================
Files 664 665 +1
Lines 20946 21049 +103
==========================================
+ Hits 18467 18564 +97
- Misses 2479 2485 +6
☔ View full report in Codecov by Sentry. |
jonasdeluna
changed the title
jonasdeluna
added
review-needed
LudvigHz
requested changes
Apr 28, 2023
jonasdeluna
force-pushed
the
imagegallery-newer
branch
3 times, most recently
from
06fb210
to
ddb60de
Compare
LudvigHz
requested changes
May 3, 2023
jonasdeluna
force-pushed
the
imagegallery-newer
branch
from
ddb60de
to
8b89a65
Compare
jonasdeluna
force-pushed
the
imagegallery-newer
branch
from
8b89a65
to
816d4ae
Compare
LudvigHz
reviewed
May 9, 2023
jonasdeluna
force-pushed
the
imagegallery-newer
branch
from
816d4ae
to
52ea193
Compare
jonasdeluna
force-pushed
the
imagegallery-newer
branch
from
52ea193
to
d353eb5
Compare
LudvigHz
approved these changes
Jul 27, 2023
| if self.instance.token != data["token"]: | ||
| raise PermissionDenied() | ||
| if "save_for_use" not in data: | ||
| raise ValidationError() |
There was a problem hiding this comment.
Would be nice to include an error message. but not critical
Comment on lines
+62
to
+66
| if serializer.is_valid(raise_exception=True): | ||
| serializer.save() | ||
| return Response(data=serializer.data, status=status.HTTP_200_OK) | ||
| else: | ||
| return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) |
There was a problem hiding this comment.
Since you have raise_exception in is_valid(), you won't execute the code path in the else block no?
Not an issue though :)
| return reverse("api:v1:files-imagegallery", kwargs={"key": key}) | ||
|
|
||
|
|
||
| class SetSaveForUserTest(BaseAPITestCase): |
There was a problem hiding this comment.
This is a super clean and thorough test! Love it!! 💯
LudvigHz
added
approved
jonasdeluna
force-pushed
the
imagegallery-newer
branch
from
d353eb5
to
8379438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement imagegallery endpoints