Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker build with poetry #3313

Merged
merged 1 commit into from Apr 19, 2023
Merged

Fix docker build with poetry #3313

merged 1 commit into from Apr 19, 2023

Conversation

eikhr
Copy link
Member

@eikhr eikhr commented Apr 19, 2023 •
edited

Changed COPY requirements /app/requirements to COPY pyproject.toml /app/pyproject.toml in Dockerfile

requirements no longer exists, causing the build to fail. pyproject.toml now contains the requirements, and is needed to install deps with poetry.

@eikhr eikhr added priority:high Pull requests that have high priority, and should therefore be prioritized small-fix Pull requests that fix something small labels Apr 19, 2023
@eikhr eikhr added the review-needed Pull requests that need review label Apr 19, 2023
LudvigHz
LudvigHz approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🙃

ivarnakken
ivarnakken approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops

@LudvigHz LudvigHz removed the review-needed Pull requests that need review label Apr 19, 2023
@ivarnakken ivarnakken added the approved Pull requests that have been approved label Apr 19, 2023
@LudvigHz LudvigHz added review-needed Pull requests that need review ready-to-merge Pull requests that have been approved and are ready to be merged and removed review-needed Pull requests that need review labels Apr 19, 2023
@LudvigHz LudvigHz enabled auto-merge April 19, 2023 09:57
@LudvigHz LudvigHz merged commit 508db84 into master Apr 19, 2023
1 check was pending
@LudvigHz LudvigHz deleted the fix-docker-build-poetry branch April 19, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudvigHz LudvigHz LudvigHz approved these changes

@ivarnakken ivarnakken ivarnakken approved these changes

@danielyanghansen danielyanghansen Awaiting requested review from danielyanghansen

@ollfkaih ollfkaih Awaiting requested review from ollfkaih

Assignees
No one assigned
Labels
approved Pull requests that have been approved priority:high Pull requests that have high priority, and should therefore be prioritized ready-to-merge Pull requests that have been approved and are ready to be merged small-fix Pull requests that fix something small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eikhr @LudvigHz @ivarnakken