Make ical feed generation of meetings not slow #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudvigHz
force-pushed
the
meeting-ical-speed
branch
2 times, most recently
from
8f6ddcc
to
5a18f21
Compare
The lookup for participating was very expensive and slow. It would cause timeouts so some users' calendars would not load.
LudvigHz
force-pushed
the
meeting-ical-speed
branch
from
5a18f21
to
57a167f
Compare
LudvigHz
force-pushed
the
meeting-ical-speed
branch
from
57a167f
to
16c3fdb
Compare
|
Sorry about the noise in the diff. I also fixed some types here and there when I was working :)) |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3321 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 661 661
Lines 20938 20949 +11
=======================================
+ Hits 18498 18508 +10
- Misses 2440 2441 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ABA-448 Fix slow ical feed generation breaking calendar sync
It has broken the calendar sync for many people |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lookup for participating was very expensive and slow. It would cause
timeouts so some users' calendars would not load.
UNTESTEDThis is my theory at least. I just wrote this code and haven't had the time to test it. But eventsdoes not suffer from this problem so I hope my suspicions are correct.
Tested the code in staging with a hotpatch. Works great now :)
Fixes ABA-448