Replace dummy HTTPConsumer with a working one #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It just responds with 405 method not allowed. IMO this is better than constant warnings when something tries to do an http request at it.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3347 +/- ##
=======================================
Coverage 88.34% 88.34%
=======================================
Files 661 661
Lines 20951 20951
=======================================
Hits 18509 18509
Misses 2442 2442
☔ View full report in Codecov by Sentry. |
LudvigHz
added
backend
bug-fix
ABA-457 Fix incorrect daphne http configuration
https://abakus.sentry.io/issues/4133264456/?referrer=slack This is not breaking but just very annoying. I also suspect that all of these messages are coming from either traefik or docker swarm doing health c hecks. These checks are also then incorrectly setup and should be fixed. |
ivarnakken
approved these changes
Apr 29, 2023
ivarnakken
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just responds with 405 method not allowed. IMO this is better than constant warnings when something tries to do an http request at it.
Fixes ABA-457