Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mypy conf for it to work as intended #3450

Merged
merged 1 commit into from Jul 13, 2023
Merged

Move mypy conf for it to work as intended #3450

merged 1 commit into from Jul 13, 2023

Conversation

ivarnakken
Copy link
Member

The quotes around the regex was originally added to comply with TOML linting, but this turned out to break the configuration. Therefore the conf had to be moved away from the TOML file.

After moving it, it appeared we were missing a required section for the django-stubs plugin, so that was also included.

@ivarnakken ivarnakken added bug-fix Pull requests that fix a bug review-needed Pull requests that need review types Pull requests that improve or fix types labels Jul 3, 2023
@ivarnakken ivarnakken requested a review from a team July 3, 2023 20:48
@ivarnakken ivarnakken self-assigned this Jul 3, 2023
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I've read a lot into mypy configuration - but if it works it looks good enough for me(:

@ivarnakken ivarnakken added approved Pull requests that have been approved ready-to-merge Pull requests that have been approved and are ready to be merged labels Jul 3, 2023
The quotes around the regex was originally added to comply with TOML linting, but this turned out to break the configuration. Therefore the conf had to be moved away from the TOML file.

After moving it, it appeared we were missing a required section for the `django-stubs` plugin, so that was also included.
@ivarnakken ivarnakken merged commit 2c1909f into master Jul 13, 2023
1 check passed
@ivarnakken ivarnakken deleted the fix-mypy-conf branch July 13, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug ready-to-merge Pull requests that have been approved and are ready to be merged review-needed Pull requests that need review types Pull requests that improve or fix types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants