Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad naming of MSTCNNS #3471

Merged
merged 1 commit into from Aug 13, 2023
Merged

Fix bad naming of MSTCNNS #3471

merged 1 commit into from Aug 13, 2023

Conversation

ivarnakken
Copy link
Member

@ivarnakken ivarnakken commented Aug 13, 2023 •
edited

I suppose it needs to be uppercase like the rest? Mock tests still pass, but there's no way for me to actually test this ..

Again, I have no idea if this actually fixes the bug 🙃 Anyone got any ideas?

@ivarnakken ivarnakken added priority:high Pull requests that have high priority, and should therefore be prioritized bug-fix Pull requests that fix a bug review-needed Pull requests that need review labels Aug 13, 2023
@ivarnakken ivarnakken requested review from eikhr, LudvigHz and a team August 13, 2023 10:46
@ivarnakken ivarnakken self-assigned this Aug 13, 2023
@ivarnakken ivarnakken added help-wanted Pull requests that want help in the form of contributions testing-needed Pull requests that need testing, e.g. stress tests by users or specs labels Aug 13, 2023
@codecov
Copy link

codecov bot commented Aug 13, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9eeb403) 88.15% compared to head (7193b3b) 88.15%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3471   +/-   ##
=======================================
  Coverage   88.15%   88.15%           
=======================================
  Files         663      663           
  Lines       20937    20937           
=======================================
  Hits        18458    18458           
  Misses       2479     2479
Files Changed Coverage Δ
.../apps/users/tests/test_student_confirmation_api.py 100.00% <ø> (ø)
lego/apps/users/constants.py 100.00% <100.00%> (ø)
lego/apps/users/models.py 95.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eikhr
eikhr approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, sikkert det som er problemet

LudvigHz
LudvigHz requested changes Aug 13, 2023
View reviewed changes
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaaah okey right but please change the code to be case invariant

@ivarnakken
Fix bad naming of studies
7193b3b 
Bug was originally MSTCNNS being lowercase unlike the others.

I suppose it's good to let this be case-insensitive. Mock tests still pass, but there's no way for me to actually test this ..
@ivarnakken ivarnakken merged commit 84aa3b7 into master Aug 13, 2023
3 checks passed
@ivarnakken ivarnakken deleted the mstcnns-feide branch August 13, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikhr eikhr eikhr approved these changes

@LudvigHz LudvigHz Awaiting requested review from LudvigHz

Assignees

@ivarnakken ivarnakken

Labels
bug-fix Pull requests that fix a bug help-wanted Pull requests that want help in the form of contributions priority:high Pull requests that have high priority, and should therefore be prioritized review-needed Pull requests that need review testing-needed Pull requests that need testing, e.g. stress tests by users or specs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivarnakken @eikhr @LudvigHz