Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement github and linkedin links on profile #3481

Merged
merged 1 commit into from Aug 31, 2023
Merged

Implement github and linkedin links on profile #3481

merged 1 commit into from Aug 31, 2023

Conversation

jonasdeluna
Copy link
Member

@jonasdeluna jonasdeluna commented Aug 30, 2023 •
edited

Implemented github and linkedin fields on user.

Blocking: webkom/lego-webapp#3901

@jonasdeluna jonasdeluna added in-progress new-feature Pull requests that introduce or issues that suggest a new feature backend do-not-merge/WIP Pull requests that are "work in progress", and should not be merged labels Aug 30, 2023
@jonasdeluna jonasdeluna added review-needed Pull requests that need review level:easy and removed do-not-merge/WIP Pull requests that are "work in progress", and should not be merged labels Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3c95733) 88.16% compared to head (4a79372) 88.16%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3481   +/-   ##
=======================================
  Coverage   88.16%   88.16%           
=======================================
  Files         663      664    +1     
  Lines       20938    20946    +8     
=======================================
+ Hits        18459    18467    +8     
  Misses       2479     2479
Files Changed Coverage Δ
lego/apps/users/serializers/users.py 95.37% <ø> (ø)
...041_user_linkedin_id_alter_user_github_username.py 100.00% <100.00%> (ø)
lego/apps/users/models.py 95.01% <100.00%> (+0.01%) ⬆️
lego/apps/users/validators.py 96.29% <100.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasdeluna jonasdeluna requested a review from a team August 31, 2023 16:01
falbru
falbru approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lego/apps/users/constants.py Outdated Show resolved Hide resolved
@jonasdeluna jonasdeluna force-pushed the github-profile-username-new branch 3 times, most recently from 97fa6b1 to 22fa68f Compare August 31, 2023 19:45
@jonasdeluna jonasdeluna merged commit f3ada16 into master Aug 31, 2023
3 checks passed
@jonasdeluna jonasdeluna deleted the github-profile-username-new branch August 31, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falbru falbru falbru approved these changes

@eikhr eikhr Awaiting requested review from eikhr

@PeterJFB PeterJFB Awaiting requested review from PeterJFB

@ivarnakken ivarnakken Awaiting requested review from ivarnakken

Assignees
No one assigned
Labels
backend in-progress level:easy new-feature Pull requests that introduce or issues that suggest a new feature review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonasdeluna @falbru