Give permission to see Allergies for Event to Responsible Group #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ivarnakken
reviewed
Sep 27, 2023
danielyanghansen
force-pushed
the
Event_ResponsibleGroupCanSeeAllergies
branch
from
713856a
to
6914518
Compare
danielyanghansen
force-pushed
the
Event_ResponsibleGroupCanSeeAllergies
branch
from
6914518
to
2d48d51
Compare
|
Looks good to me :) |
Arashfa0301
approved these changes
Sep 27, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3495 +/- ##
=======================================
Coverage 88.20% 88.21%
=======================================
Files 666 666
Lines 21069 21083 +14
=======================================
+ Hits 18584 18598 +14
Misses 2485 2485
☔ View full report in Codecov by Sentry. |
jonasdeluna
approved these changes
Sep 28, 2023
|
Resolves: ABA-589 |
Signed-off-by: Daniel Yang Hansen <daniel.yang.hansen@gmail.com>
danielyanghansen
force-pushed
the
Event_ResponsibleGroupCanSeeAllergies
branch
from
2d48d51
to
efb0226
Compare
Signed-off-by: Daniel Yang Hansen <daniel.yang.hansen@gmail.com>
Signed-off-by: Daniel Yang Hansen <daniel.yang.hansen@gmail.com>
Signed-off-by: Daniel Yang Hansen <daniel.yang.hansen@gmail.com>
|
Tests run fine ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend checks if user is part of responsible group when delegating authorization to view allergies.
The corresponding serializer has also been updated to include the "ResponsibleGroup" field so that frontend also can check if user should be able to see the allergy tab
Resolves: ABA-589