Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add revue to the permitted groups for the contact form #3511

Merged
merged 1 commit into from Oct 30, 2023

Conversation

falbru
Copy link
Contributor

@falbru falbru commented Oct 20, 2023

Initially, I wanted to add support for only contacting the revue board. However, the only way to achieve that would be to hardcode in the group id (or handle RevyStyret as a special group like we do Hovedstyret). I decided to just add support for all revue groups, because that was a lot easier.

Related to this PR.

Copy link
Member

@danielyanghansen danielyanghansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think it's quite nice to allow all of the revue groups to be contacted. The subgroups have leaders anyway, and groups like the band can deffo be relevant to contact (if they want to be available)

anyways: Looks good

Copy link
Member

@jonasdeluna jonasdeluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there a frontend change adding the revue to the group picker or is that automatic?

@falbru
Copy link
Contributor Author

falbru commented Oct 27, 2023

LGTM, is there a frontend change adding the revue to the group picker or is that automatic?

Yup. This one.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e6a8dc) 88.21% compared to head (c3d75cc) 88.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3511   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files         666      666           
  Lines       21083    21084    +1     
=======================================
+ Hits        18598    18599    +1     
  Misses       2485     2485           
Files Coverage Δ
lego/apps/contact/serializers.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@falbru falbru merged commit 249e67c into master Oct 30, 2023
3 checks passed
@falbru falbru deleted the add-revue-to-contact-form branch October 30, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants