Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement boolean field on event for foreign language. #3513

Merged
merged 1 commit into from Nov 2, 2023

Conversation

jonasdeluna
Copy link
Member

@jonasdeluna jonasdeluna commented Oct 31, 2023

Ref email

Resolves: ABA-649

Copy link

linear bot commented Oct 31, 2023

@jonasdeluna jonasdeluna force-pushed the implement-foreign-language-field-on-events branch from bac9f02 to 5173b73 Compare October 31, 2023 18:31
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (249e67c) 88.21% compared to head (5173b73) 88.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3513   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files         666      667    +1     
  Lines       21084    21089    +5     
=======================================
+ Hits        18599    18604    +5     
  Misses       2485     2485           
Files Coverage Δ
...vents/migrations/0038_event_is_foreign_language.py 100.00% <100.00%> (ø)
lego/apps/events/models.py 97.22% <100.00%> (+<0.01%) ⬆️
lego/apps/events/serializers/events.py 96.98% <ø> (ø)
lego/apps/events/tests/test_events_api.py 89.47% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@danielyanghansen danielyanghansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jonasdeluna jonasdeluna merged commit 48d263b into master Nov 2, 2023
3 checks passed
@jonasdeluna jonasdeluna deleted the implement-foreign-language-field-on-events branch November 2, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants