New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Individual reactions #3520
Individual reactions #3520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all is good
however PublicUserSerializer already gives out the id
so their no need to say
class ReactionsSerializer(serializers.ModelSerializer):
author = PublicUserSerializer(read_only=True, source="created_by")
class Meta:
model = Reaction
fields = ("id", "emoji", "created_by", "created_at", "author")
read_only = True
just remove author from the fields and rename it to created_by
class ReactionsSerializer(serializers.ModelSerializer):
created_by = PublicUserSerializer(read_only=True)
class Meta:
model = Reaction
fields = ("id", "emoji", "created_by", "created_at")
read_only = True
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3520 +/- ##
=======================================
Coverage 88.21% 88.21%
=======================================
Files 666 666
Lines 21083 21091 +8
=======================================
+ Hits 18598 18606 +8
Misses 2485 2485 ☔ View full report in Codecov by Sentry. |
Adds a new field,
reactions
for the meeting serializer. This is used to show who reacted on the meeting on the frontend.Frontend PR.
Screencast.from.08.nov.2023.kl.15.37.+0100.webm