Edit booking period #3525
Merged
Edit booking period #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3525 +/- ##
=======================================
Coverage 88.21% 88.21%
=======================================
Files 667 667
Lines 21089 21089
=======================================
Hits 18604 18604
Misses 2485 2485 ☔ View full report in Codecov by Sentry. |
eikhr
approved these changes
Nov 14, 2023
juniwbjerde
reviewed
Nov 14, 2023
| @@ -22,7 +22,7 @@ | |||
| PENALTY_IGNORE_SUMMER = ((6, 1), (8, 15)) | |||
| PENALTY_IGNORE_WINTER = ((11, 18), (1, 10)) | |||
|
|
|||
| BEDKOM_BOOKING_PERIOD = ((10, 2), (10, 19)) | |||
| BEDKOM_BOOKING_PERIOD = ((1, 1), (12, 30)) | |||
There was a problem hiding this comment.
Desember has 31 days, not 30. I assume nobody sends company interests on new years eve, but it's very random to have auto reply on every day of the year except for one...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit booking period