Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admissions oauth fixture #3550

Merged
merged 1 commit into from Jan 26, 2024
Merged

Add admissions oauth fixture #3550

merged 1 commit into from Jan 26, 2024

Conversation

norbye
Copy link
Member

@norbye norbye commented Jan 25, 2024

Makes it so that you don't have to create your own oauth application when devving in admissions - you can just load the fixtures and voilá

image

you can log in with your local LEGO instance

@norbye norbye added the review-needed Pull requests that need review label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bf887c9) 88.24% compared to head (61e8ba8) 88.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3550   +/-   ##
=======================================
  Coverage   88.24%   88.24%           
=======================================
  Files         668      668           
  Lines       21112    21112           
=======================================
  Hits        18630    18630           
  Misses       2482     2482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool I never thought of that!

@norbye norbye added approved Pull requests that have been approved and removed review-needed Pull requests that need review labels Jan 25, 2024
@norbye norbye merged commit 85b894a into master Jan 26, 2024
3 checks passed
@norbye norbye deleted the add-admissions-oauth branch January 26, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Pull requests that have been approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants