Stylistic changes #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good (although I'm ambivalent about the closing ends stuff). Since I've already merged the Dispatcher change, could you change all of those appropriately and then merge? Thanks. By the way, welcome to the committers! |
|
@seancribbs — Thanks! I'm loving Webmachine so far. I've got lots of ideas bouncing around in my head about things to do with it :). I rebased this branch on top of your current master and it looks like everything is a-ok. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a couple of stylistic changes. The annotated
endkeywords are clearly a matter of taste, but I find it helpful when navigating nested modules. The implicit exception handling scope of method definition is always better, in my view; hopefully you agree :).